Mike Kolesnik has posted comments on this change. Change subject: engine: Report event for external port removal failure ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/30613/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java: Line 66: providerProxy.deallocate(nic); Line 67: } catch (VdcBLLException e) { Line 68: AuditLogableBase removePortFailureEvent = new AuditLogableBase(); Line 69: removePortFailureEvent.addCustomValue("PortName", nic.getName()); Line 70: removePortFailureEvent.addCustomValue("PortId", nic.getId().toString()); This is the internal ID, perhaps you mean NicID? Line 71: removePortFailureEvent.addCustomValue("ProviderName", provider.getName()); Line 72: AuditLogDirector.log(removePortFailureEvent, AuditLogType.REMOVE_PORT_FROM_EXTERNAL_PROVIDER_FAILED); Line 73: } Line 74: } http://gerrit.ovirt.org/#/c/30613/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 508: NETWORK_ATTACH_NETWORK_TO_VDS_GROUP=Network ${NetworkName} attached to Cluster ${VdsGroupName} Line 509: NETWORK_ATTACH_NETWORK_TO_VDS_GROUP_FAILED=Failed to attach Network ${NetworkName} to Cluster ${VdsGroupName} Line 510: NETWORK_DETACH_NETWORK_TO_VDS_GROUP=Network ${NetworkName} detached from Cluster ${VdsGroupName} Line 511: NETWORK_DETACH_NETWORK_TO_VDS_GROUP_FAILED=Failed to detach Network ${NetworkName} from Cluster ${VdsGroupName} Line 512: REMOVE_PORT_FROM_EXTERNAL_PROVIDER_FAILED=Failed to remove port ${PortName} (${PortId}) from external network provider ${ProviderName}. Should say vNIC or something like that, port is strictly Neutron terminology and so far we have refrained from using non-generic terminology in messages.. Also just saying the Id isn't very clear, should perhaps sy something like 'can be identified by id' Line 513: NETWORK_ACTIVATE_VM_INTERFACE_SUCCESS=Network Interface ${InterfaceName} (${InterfaceType}) was plugged to VM ${VmName}. (User: ${UserName}) Line 514: NETWORK_ACTIVATE_VM_INTERFACE_FAILURE=Failed to plug Network Interface ${InterfaceName} (${InterfaceType}) to VM ${VmName}. (User: ${UserName}) Line 515: NETWORK_DEACTIVATE_VM_INTERFACE_SUCCESS=Network Interface ${InterfaceName} (${InterfaceType}) was unplugged from VM ${VmName}. (User: ${UserName}) Line 516: NETWORK_DEACTIVATE_VM_INTERFACE_FAILURE=Failed to unplug Network Interface ${InterfaceName} (${InterfaceType}) from VM ${VmName}. (User: ${UserName}) -- To view, visit http://gerrit.ovirt.org/30613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57d42da98ff1c86f242f53204520fd4e219b3205 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
