Omer Frenkel has posted comments on this change. Change subject: core: Added short term history of VM cpu/memory/network usage ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29710/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java: Line 284: Line 285: for (int i = 0; i < numOfValues - limit; i++) { Line 286: // cut the beginning so it will not be too long Line 287: res = res.substring(res.indexOf(',') + 1, res.length()); Line 288: } why not working with array list and avoid all of this? we can still save it to db how ever we like, but in the code work with objects.. Line 289: Line 290: return res; Line 291: } -- To view, visit http://gerrit.ovirt.org/29710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5275c224df83caf5078062e14121847940eac44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
