Alona Kaplan has posted comments on this change. Change subject: engine: Throw canDo on addVmCommand if template is not in cluster ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30638/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 1327: getParameters().getVmStaticData().setDefaultDisplayType(defaultDisplayType); Line 1328: } Line 1329: } Line 1330: Line 1331: protected boolean isValidTemplate() { > but it validate only the template dc, not everything, like if its null, dis Done Line 1332: return getVmTemplate().getStoragePoolId().equals(getStoragePoolId()); Line 1333: } Line 1334: -- To view, visit http://gerrit.ovirt.org/30638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2566b18049bf7603700572dc5d419a640f294ada Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
