Eli Mesika has posted comments on this change. Change subject: [WIP] core: db changes to add association between tasks and entities ......................................................................
Patch Set 5: (3 inline comments) .................................................... File backend/manager/dbscripts/async_tasks_sp.sql Line 57: CREATE OR REPLACE FUNCTION Getasync_tasksByentity_id(v_entity_id UUID) please remove _ from the function name and use word capitalization like in your 1st function Line 64: CREATE GLOBAL TEMPORARY TABLE tt_TEMP I would like to get rid of those meaningless names and give a descriptive one .................................................... File backend/manager/dbscripts/upgrade/03_01_1270_add_async_task_entities_table.sql Line 1: CREATE OR REPLACE FUNCTION __temp_Upgrade_add_async_task_entities_table() You have 2 upgrade scripts with 1270 numbering in this patch and the next one, please change to have unique upgrade numbers before you final patch is pushed -- To view, visit http://gerrit.ovirt.org/5994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a711e932ffb7bcc6920a3456ac97f8b8fc18a76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
