Lior Vernia has posted comments on this change. Change subject: webadmin: Wrong vnics when creating vm from blank template ......................................................................
Patch Set 1: Code-Review+2 (2 comments) Note small inline comment. http://gerrit.ovirt.org/#/c/30637/1//COMMIT_MSG Commit Message: Line 13: Line 14: This override happens in EditProfileBehavior->initSelectedProfile, but Line 15: since it is called before the registration of ProfileInstanceTypeEditor Line 16: to SelectedItemChangedEvent of VnicInstanceType the new selection of Line 17: 'Empty' profile isn't reflected on VnicInstanceType.NetworkInterface. > Disregard the first paragraph, it's irrelevant because that's not what you A-ha, sorry, was confused by what's written in the bug as the expected result, which was wrong. Your fix looks good. Line 18: Line 19: This patch fixes it by calling syncSelectedItemWithNetworkInterface(..) Line 20: also before the registration and not just from the eventRaised(..). Line 21: http://gerrit.ovirt.org/#/c/30637/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfileInstanceTypeEditor.java: Line 70: @Override Line 71: public void edit(final VnicInstanceType model) { Line 72: driver.edit(model); Line 73: Line 74: String vnicName = model.getNetworkInterface().getName(); This variable is used only once, so can probably be removed and inlined in line 78. Line 75: Line 76: profileEditor.addLabelStyleName(style.noDisplay()); Line 77: profileEditor.addContentWidgetStyleName(style.contentStyle()); Line 78: profileEditor.setElementId(ElementIdUtils.createElementId(elementId, vnicName)); -- To view, visit http://gerrit.ovirt.org/30637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60be6b21050c43bb004e56688f8e306b5b943d24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
