Moti Asayag has posted comments on this change. Change subject: core: missing PermissionSubject in storage command base ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java Line 310: permissionCheckSubjects.addAll(super.getPermissionCheckSubjects()); I don't think that this is the right solution, since this will modify any command inherited from StorageDomainCommandBase will require permission on the StoragePool, else it will have to override this method to maintain current behaviour. For task/job description, you should override CommandBase.getJobMessageProperties() to provide the required properties for substitute the place holder. -- To view, visit http://gerrit.ovirt.org/6029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48e501cbe8f261ddc1ecf7f17a754f5c2a5bacf8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
