Martin Mucha has posted comments on this change. Change subject: core: IdParameters should contain @NotNull validation ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/30569/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java: Line 17: private MacPool oldMacPool; Line 18: Line 19: public RemoveMacPoolCommand(IdParameters parameters) { Line 20: super(parameters); Line 21: addValidationGroup(RemoveEntity.class); > This should be in the getValidationGroups method. you're right. I shouldn't be overriding that method, I've forget to delete it. But I think not overriding method is more appropriate, when there's something like 'setter'. Sorry about this stupid error. Line 22: } Line 23: Line 24: @Override Line 25: protected void setActionMessageParameters() { -- To view, visit http://gerrit.ovirt.org/30569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cda909ffc16aa3b844faa7c2e7cd323a0769db1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
