Alona Kaplan has posted comments on this change. Change subject: webadmin: Network dialog- field validation indication for tabs ......................................................................
Patch Set 2: (2 comments) You are right. The tab validation definitely should be done in a more generic manner. But since now we are backporting bugs to ovirt_35, I don't think it is the time to do such infra change. Can be done as a feature to 3.6:) http://gerrit.ovirt.org/#/c/30664/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 76: private UICommand addQosCommand; Line 77: private final Network network; Line 78: private final ListModel sourceListModel; Line 79: private boolean isGeneralTabValid; Line 80: private boolean isVnicProfileTabValid; > You're missing the subnets tab, available when the network is marked to be Done Line 81: Line 82: public NetworkModel(ListModel sourceListModel) Line 83: { Line 84: this(new Network(), sourceListModel); Line 497: getNetworkLabel().validateSelectedItem(new IValidation[] { new AsciiNameValidation() }); Line 498: Line 499: setIsGeneralTabValid(getName().getIsValid() && getVLanTag().getIsValid() && getDescription().getIsValid() Line 500: && getMtu().getIsValid() && getExternalProviders().getIsValid() && getComment().getIsValid() Line 501: && subnetValid && getNetworkLabel().getIsValid()); > subnetValid should be the input for the subnets tab's validation. Done Line 502: setIsVnicProfileTabValid(profilesValid); Line 503: return getIsGeneralTabValid() && getIsVnicProfileTabValid(); Line 504: } Line 505: -- To view, visit http://gerrit.ovirt.org/30664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b9cfd6d4c8fcb4768c99c42393dd0d0c72f7cbd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
