Moti Asayag has posted comments on this change. Change subject: engine: Add command to update cluster network ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkOnClusterCommand.java Line 52: return getNetworkClusterDAO().get(getParameters().getNetworkCluster().getId()) == null ? this is a potential NPE - getParameters().getNetworkCluster().getId() - see comment in previous patch regarding adding @NotNull for NetworkClusterParameters.networkCluster -- To view, visit http://gerrit.ovirt.org/6023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c85099df16fe6cdffba33108bcb3ec570642ea0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
