Jiří Moskovčák has posted comments on this change. Change subject: packaging: setup: fixing checks on create_volume exit codes ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30277/1/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 261: logger.info("Image for '%s' already exists", service_name) Line 262: path = response['path'] Line 263: return False, path Line 264: Line 265: elif response["status"]["code"] not in (100, 254): > I had to re-enable also 100 otherwise it always hangs on my setup. according to the code 100 means GeneralException. I don't know when or if it changed, but you should be able to find it in vdsm git log. Line 266: # 100 is returned when the volume doesn't exist Line 267: # 254 is returned when Image path doesn't exist Line 268: raise RuntimeError(response["status"]["message"]) Line 269: -- To view, visit http://gerrit.ovirt.org/30277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859e52351e163687e805395461f8477773b32700 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
