Ravi Nori has posted comments on this change. Change subject: engine : CommandExecutor should handle exception in CallBackMethods ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/30463/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 67: callBack.onFailed(cmdId, coco.getChildCommandIds(cmdId)); Line 68: } catch (Exception ex) { Line 69: handleError(ex, status, cmdId); Line 70: } Line 71: coco.updateCallBackNotified(cmdId); > I have suggested that before... we can have the switch..case inside a try.. will do Line 72: iterator.remove(); Line 73: break; Line 74: case SUCCEEDED: Line 75: try { Line 73: break; Line 74: case SUCCEEDED: Line 75: try { Line 76: callBack.onSucceeded(cmdId, coco.getChildCommandIds(cmdId)); Line 77: coco.updateCallBackNotified(cmdId); > Duplicated after try/catch block Will remove Line 78: iterator.remove(); Line 79: } catch (Exception ex) { Line 80: handleError(ex, status, cmdId); Line 81: } -- To view, visit http://gerrit.ovirt.org/30463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b82f29ac31fd09903d76f87e839d8ac32ef1e1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
