Gilad Chaplik has posted comments on this change. Change subject: engine: NUMA feature queries and actions validation ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27617/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java: Line 38: } Line 39: VM vm = getVm(); Line 40: boolean pinHost = vm.getMigrationSupport() == MigrationSupport.PINNED_TO_HOST; Line 41: Guid vdsId = vm.getDedicatedVmForVds(); Line 42: if (pinHost && vdsId == null) { > How to use the ConfigurationValues, do you have document for details, or so add it to ConfigValues.java, and packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql. set it with false, this will allow advanced users to enable it, and allow migration with numa. Line 43: return failCanDoAction(VdcBllMessages.VM_NUMA_PINNED_VDS_NOT_EXIST); Line 44: } Line 45: List<VdsNumaNode> vdsNumaNodes = new ArrayList<>(); Line 46: if (pinHost) { -- To view, visit http://gerrit.ovirt.org/27617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c299405ec5d82ada713ed3d220554bf3055c145 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jason Liao <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
