Shubhendu Tripathi has posted comments on this change. Change subject: engine : VDS Command for geo-replication session create ......................................................................
Patch Set 7: (5 comments) http://gerrit.ovirt.org/#/c/29833/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 373: GLUSTER_VOLUME_REBALANCE_NOT_FOUND_FROM_CLI(4091, AuditLogSeverity.WARNING), Line 374: REMOVE_GLUSTER_VOLUME_BRICKS_NOT_FOUND_FROM_CLI(4092, AuditLogSeverity.WARNING), Line 375: GLUSTER_VOLUME_DETAILS_REFRESH(4093), Line 376: GLUSTER_VOLUME_DETAILS_REFRESH_FAILED(4094, AuditLogSeverity.ERROR), Line 377: GLUSTER_VOLUME_GEO_REP_CREATE(4099), Place the error codes in order Line 378: GLUSTER_VOLUME_GEO_REP_CREATE_FAILED(4096, AuditLogSeverity.ERROR), Line 379: GLUSTER_VOLUME_PASSWORD_LESS_SSH_FAILED(4097, AuditLogSeverity.ERROR), Line 380: Line 381: USER_FORCE_SELECTED_SPM(159), http://gerrit.ovirt.org/#/c/29833/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 85: VAR__ACTION__HOT_PLUG, Line 86: VAR__ACTION__HOT_UNPLUG, Line 87: VAR__ACTION__LOGON, Line 88: VAR__ACTION__LOGOFF, Line 89: VAR_ACTION_CREATE_GEO_REPLICATION_SESSION, Mostly the verb part comes in the last in most of the entries. It could be VAR_ACTION_GE_REP_SESSION_CREATE Line 90: VAR__ACTION__REBALANCE_START, Line 91: VAR__ACTION__REBALANCE_STOP, Line 92: VAR__ACTION__REMOVE_BRICKS_START, Line 93: VAR__ACTION__ASSIGN, http://gerrit.ovirt.org/#/c/29833/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 158: GetGlusterVolumeRebalanceStatus("org.ovirt.engine.core.vdsbroker.gluster"), Line 159: GetDiskAlignment("org.ovirt.engine.core.vdsbroker.vdsbroker"), Line 160: GlusterTasksList("org.ovirt.engine.core.vdsbroker.gluster"), Line 161: GetGlusterVolumeRemoveBricksStatus("org.ovirt.engine.core.vdsbroker.gluster"), Line 162: GlusterVolumeCreatePasswordLessSSHSession("org.ovirt.engine.core.vdsbroker.gluster"), Creation of password less ssh session does not have anything to do with gluster volume, so I feel name need not start with GlusterVolume* Line 163: SetNumberOfCpus("org.ovirt.engine.core.vdsbroker"), Line 164: List("org.ovirt.engine.core.vdsbroker.vdsbroker"), // get a list of VMs with status only Line 165: GetVmStats("org.ovirt.engine.core.vdsbroker.vdsbroker"), // get a VM with full data and statistics Line 166: GetAllVmStats("org.ovirt.engine.core.vdsbroker.vdsbroker"); // get a list of VMs with full data and statistics http://gerrit.ovirt.org/#/c/29833/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeCreatePasswordLessSSHSessionVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeCreatePasswordLessSSHSessionVDSCommand.java: Line 2: Line 3: import org.ovirt.engine.core.common.errors.VdcBllErrors; Line 4: import org.ovirt.engine.core.common.vdscommands.gluster.GlusterSshSessionParameters; Line 5: Line 6: public class GlusterVolumeCreatePasswordLessSSHSessionVDSCommand<P extends GlusterSshSessionParameters> extends AbstractGlusterBrokerCommand<P> { Same as before regarding the name of the class Line 7: Line 8: public GlusterVolumeCreatePasswordLessSSHSessionVDSCommand(P parameters) { Line 9: super(parameters); Line 10: } http://gerrit.ovirt.org/#/c/29833/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java: Line 238: public Map<String, Object> replaceGlusterVolumeBrickStart(String volumeName, String existingBrickDir, String newBrickDir); Line 239: Line 240: public Map<String, Object> glusterHostRemove(String hostName, Boolean force); Line 241: Line 242: public Map<String, Object> glusterVolumeReplaceBrickStart(String volumeName, String existingBrickDir, String newBrickDir); Here we are using master server id whereas for the slave we are using name / ip only. Any specific reason ? Line 243: Line 244: public Map<String, Object> glusterVolumeCreateGeoRepSession(Guid masterServerId, String masterVolumeName, String slaveServerIp, String slaveVolumeName); Line 245: Line 246: public Map<String, Object> glusterValidateSshConnection(String hostName, String fingerPrint, String userName); -- To view, visit http://gerrit.ovirt.org/29833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
