Daniel Erez has posted comments on this change. Change subject: core: add disk - storage domain not specified error message ......................................................................
Patch Set 1: (2 comments) @Allon - yes, the UI explicitly sets the storage domain. http://gerrit.ovirt.org/#/c/30633/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java: Line 165: return true; Line 166: } Line 167: Line 168: protected boolean checkIfImageDiskCanBeAdded(VM vm, DiskValidator diskValidator) { Line 169: if (Guid.Empty.equals(getParameters().getStorageDomainId()) && Guid.Empty.equals(getStorageDomainId())) { > from brief look, you could narrow it down to check only getStorageDomainId( Done Line 170: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_SPECIFIED); Line 171: } Line 172: Line 173: boolean returnValue; http://gerrit.ovirt.org/#/c/30633/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 250: ACTION_TYPE_FAILED_ROLE_IS_READ_ONLY=Cannot ${action} ${type}. The Role is Read-Only. Line 251: ACTION_TYPE_FAILED_STORAGE_POOL_NOT_MATCH=Cannot ${action} ${type}. The target Data Center does not contain the ${type}. Line 252: ACTION_TYPE_FAILED_STORAGE_POOL_OF_VM_NOT_MATCH=Cannot ${action} ${type}. The target Data Center does not contain the Virtual Machine. Line 253: ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_CONTAINS_DISK=Cannot ${action} ${type}. The Storage Domain already contains the target disk(s). Line 254: ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_SPECIFIED=Cannot ${action} ${type}. Storage Domain hasn't been specified. > perhaps we can also add to the message that we couldn't find any domain usi This message is relevant only when there aren't other vm disks.. Line 255: ACTION_TYPE_FAILED_STORAGE_DELETE_PROTECTED=Cannot ${action} ${type}. The following VMs/Templates are delete protected: ${vms}. Line 256: ACTION_TYPE_FAILED_STORAGE_VMS_IN_POOL=Cannot ${action} ${type}. The following VMs/Templates are attached to pool: ${vms}. Line 257: ACTION_TYPE_FAILED_STORAGE_DOMAIN_NAME_ALREADY_EXIST=Cannot ${action} ${type}. The Storage Domain name is already in use. Line 258: ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_EXIST=Cannot ${action} ${type}. The Storage Domain already exists. -- To view, visit http://gerrit.ovirt.org/30633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd74f8ecd23b3c01108c31a0bb46f99002fd7071 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
