Oved Ourfali has posted comments on this change. Change subject: core: add host_provider_id to vdsStatic ......................................................................
Patch Set 6: Code-Review-1 (3 comments) see comments about empty vs null http://gerrit.ovirt.org/#/c/30059/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 284: getParameters().getSSHPort(), Line 285: getParameters().getSSHUser(), Line 286: vdsGroupId, Guid.Empty, Line 287: getParameters().getVdsName(), Config.<Boolean> getValue(ConfigValues.SSLEnabled), Line 288: VDSType.VDS, Guid.Empty); should be null. Line 289: vds.setSshKeyFingerprint(getParameters().getSSHFingerprint()); Line 290: Line 291: log.debugFormat( Line 292: "RegisterVdsQuery::Register - Will try now to add VDS from scratch; Name: {0}, Hostname: {1}, Unique: {2}, VdsPort: {3},Subnet mask: {4}, IsPending: {5} with force synchronize", http://gerrit.ovirt.org/#/c/30059/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java: Line 193: autoRecoverable = true; Line 194: disablePowerManagementPolicy = false; Line 195: pmKdumpDetection = true; Line 196: this.protocol = VdsProtocol.XML; Line 197: this.hostProviderId = Guid.Empty; should be null. Line 198: } Line 199: Line 200: public VdsStatic(String host_name, String ip, String uniqueId, int port, int ssh_port, String ssh_username, Guid vds_group_id, Guid vds_id, Line 201: String vds_name, boolean server_SSL_enabled, VDSType vds_type, Guid host_provider_id) { http://gerrit.ovirt.org/#/c/30059/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java: Line 163: entity.setOtpValidity(rs.getLong("otp_validity")); Line 164: entity.setSshKeyFingerprint(rs.getString("sshKeyFingerprint")); Line 165: entity.setConsoleAddress(rs.getString("console_address")); Line 166: entity.setDisablePowerManagementPolicy(rs.getBoolean("disable_auto_pm")); Line 167: entity.setHostProviderId(getGuidDefaultEmpty(rs, "host_provider_id")); default should be null. Line 168: Line 169: return entity; Line 170: } Line 171: } -- To view, visit http://gerrit.ovirt.org/30059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
