Juan Hernandez has posted comments on this change. Change subject: sdk: Save attributes to decorated object ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30653/3/src/ovirtsdk/infrastructure/common.py File src/ovirtsdk/infrastructure/common.py: Line 58: decorated = self.__dict__.get(DECORATED_ATTR) Line 59: if decorated is not None: Line 60: setattr(decorated, name, value) Line 61: else: Line 62: self.__dict__[name] = value > 1. Typos in attribute names are silently ignored by Python anyhow: Regarding 2: Actually this can't be changed, because this class is used as base class for collections, and they don't have a reference to any decorator. Si if we raise an exception here then any access to attributes of those classes will fail. Line 63: Line 64: def __eq__(self, other): Line 65: return Comparator.compare(self, other) Line 66: -- To view, visit http://gerrit.ovirt.org/30653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a4c5e08f844b250b585508c962fc0c38f9aad98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
