Omer Frenkel has posted comments on this change. Change subject: core: monitoring - Create a VM manager to co-ordinate monitoring and commands ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/28173/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java: Line 126: } Line 127: } Line 128: Line 129: removeMemoryVolumes(); Line 130: ResourceManager.getInstance().onVmDelete(getVmId()); i dont like this way of direct access to the resource manager we should use VDSCommands for that Line 131: return true; Line 132: } Line 133: Line 134: private void removeMemoryVolumes() { http://gerrit.ovirt.org/#/c/28173/8/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java: Line 117: private void handleCommandResult(CreateVDSCommand<?> command) { Line 118: if (!command.getVDSReturnValue().getSucceeded() && command.getVDSReturnValue().getExceptionObject() != null) { Line 119: if (command.getVDSReturnValue().getExceptionObject() instanceof VDSGenericException) { Line 120: log.errorFormat("VDS::create Failed creating vm '{0}' in vds = {1} error = {2}", Line 121: getParameters().getVm().getName(), getParameters().getVdsId(), i think you can use here getAndSetVdsStatic() to get the vds name, so we will have it in the log, i think it is called anyway for the logging infrastructure ("FINISH") Line 122: command.getVDSReturnValue().getExceptionString()); Line 123: getVDSReturnValue().setReturnValue(VMStatus.Down); Line 124: getVDSReturnValue().setSucceeded(false); Line 125: getVDSReturnValue().setExceptionString(command.getVDSReturnValue().getExceptionString()); -- To view, visit http://gerrit.ovirt.org/28173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
