Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: IE9 header value ......................................................................
userportal,webadmin: IE9 header value - Fixed issue where IE9 was reporting missing headers as blank instead of null. This would cause initialization routined to be executed, and that would cause another request which would cause the header to be missing again and one would end up in an endless loop of requests. The patch checks for both null and blank so the loop never happens. Change-Id: I4144a585a1dec1e736d30f7b7b698687543f7936 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114863 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/30768/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java index 45ff5b1..8c082b5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java @@ -125,7 +125,8 @@ @Override public void onResponseReceived(Request request, Response response) { String tokenValue = response.getHeader("OVIRT-SSO-TOKEN"); //$NON-NLS-1$ - if (tokenValue != null) { + //Need to check for "" as well, as IE9 reports missing headers as blank instead of null. + if (tokenValue != null && !"".equals(tokenValue)) { //$NON-NLS-1$ //Login result received. SSOTokenChangeEvent.fire(eventBus, tokenValue); } -- To view, visit http://gerrit.ovirt.org/30768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4144a585a1dec1e736d30f7b7b698687543f7936 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
