Liron Aravot has posted comments on this change. Change subject: core: disk profile commands and queries ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/28732/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddDiskProfileCommand.java: Line 33: setSucceeded(true); Line 34: } Line 35: Line 36: @Override Line 37: public List<PermissionSubject> getPermissionCheckSubjects() { > see elaborate explanation in: commented there as well Line 38: return Collections.singletonList(new PermissionSubject(getParameters().getProfile() != null ? getParameters().getProfile() Line 39: .getStorageDomainId() Line 40: : null, Line 41: VdcObjectType.Storage, getActionType().getActionGroup())); -- To view, visit http://gerrit.ovirt.org/28732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d871f1603671bc14ce88c68f85638b1af67f5e1 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
