Alona Kaplan has uploaded a new change for review. Change subject: engine: Attach/Detach two (or more) nets with lables to cluster fails ......................................................................
engine: Attach/Detach two (or more) nets with lables to cluster fails When more than one network with a label is attached/detached to/from a cluster via multiple action- Attach/DetachNetworkToVdsGroup an internal command Attach/DetachNetworksFromCluster is called. Due to changes in internal commands protocol- commands that are called internally should have two ctors- 1. Ctor(T parameters) 2. Ctor(T parameters, CommandContext cmdContext) Since the Attach/DetachNetworkToVdsGroup didn't have the first ctor there was an exception. Change-Id: I8862de722b42360d215285e3bd29708cc5ceec68 Signed-off-by: Alona Kaplan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java 2 files changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/30791/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java index 381ef46..b644041 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java @@ -1,7 +1,5 @@ package org.ovirt.engine.core.bll.network.cluster; -import org.ovirt.engine.core.bll.context.CommandContext; - import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; @@ -14,6 +12,7 @@ import org.ovirt.engine.core.bll.InternalCommandAttribute; import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute; import org.ovirt.engine.core.bll.VdsGroupCommandBase; +import org.ovirt.engine.core.bll.context.CommandContext; import org.ovirt.engine.core.bll.network.AddNetworksByLabelParametersBuilder; import org.ovirt.engine.core.bll.network.NetworkParametersBuilder; import org.ovirt.engine.core.bll.utils.PermissionSubject; @@ -31,6 +30,10 @@ @NonTransactiveCommandAttribute public class AttachNetworksToClusterCommand<T extends ClusterNetworksParameters> extends VdsGroupCommandBase<T> { + public AttachNetworksToClusterCommand(T parameters) { + super(parameters); + } + public AttachNetworksToClusterCommand(T parameters, CommandContext cmdContext) { super(parameters, cmdContext); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java index 9ce9a69..09e8b55 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java @@ -1,7 +1,5 @@ package org.ovirt.engine.core.bll.network.cluster; -import org.ovirt.engine.core.bll.context.CommandContext; - import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; @@ -14,6 +12,7 @@ import org.ovirt.engine.core.bll.InternalCommandAttribute; import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute; import org.ovirt.engine.core.bll.VdsGroupCommandBase; +import org.ovirt.engine.core.bll.context.CommandContext; import org.ovirt.engine.core.bll.network.NetworkParametersBuilder; import org.ovirt.engine.core.bll.network.RemoveNetworksByLabelParametersBuilder; import org.ovirt.engine.core.bll.utils.PermissionSubject; @@ -31,6 +30,10 @@ @NonTransactiveCommandAttribute public class DetachNetworksFromClusterCommand<T extends ClusterNetworksParameters> extends VdsGroupCommandBase<T> { + public DetachNetworksFromClusterCommand(T parameters) { + super(parameters); + } + public DetachNetworksFromClusterCommand(T parameters, CommandContext cmdContext) { super(parameters, cmdContext); } -- To view, visit http://gerrit.ovirt.org/30791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8862de722b42360d215285e3bd29708cc5ceec68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
