Simone Tiraboschi has posted comments on this change.

Change subject: packaging: setup: cluster comp. level as max common between 
vdsm and engine
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/30586/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py:

Line 233:                 for vs in [
Line 234:                     x for x in eSupportedClusterLevels.split(',')
Line 235:                     if x in vSupportedClusterLevels
Line 236:                 ]
Line 237:             )
> nicer indeed.
Done
Line 238:         except ValueError:
Line 239:             self.logger.debug('exception', exc_info=True)
Line 240:             raise RuntimeError(_(
Line 241:                 'Failed to find a ClusterLevel supported '


-- 
To view, visit http://gerrit.ovirt.org/30586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf1b04e7c087ef70ccceb83fdbff8caf7e2942e2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to