Tomas Jelinek has uploaded a new change for review.

Change subject: webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog
......................................................................

webadmin: Overlapped in 'New Virtual Machine - Guide Me' dialog

In fr_FR locale the text did not fit into buttons in new VM guide me dialog.

Fixed by changing the styles in a way that when the text is longer than 200px
(min widt) than the button grows.

Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8
Bug-Url: https://bugzilla.redhat.com/1123762
Signed-off-by: Tomas Jelinek <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
2 files changed, 2 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/30821/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
index ac86133..4f2181c 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
@@ -36,8 +36,8 @@
     @Template("<table cellspacing='0' cellpadding='0'><tr>" +
             "<td style='background: url({2});width:2px;'></td>" +
             "<td style='text-align:center;'>" +
-            "<div class='db_bg_image {5} {6}' style='background: url({3}) 
repeat-x; height: 20px;'>" +
-            "<span style='vertical-align: middle; line-height: 20px;' 
class=\"db_image_container\">{0}</span><div class=\"db_text\">{1}</div></div>" +
+            "<div class='db_bg_image {5} {6}' style='background: url({3}) 
repeat-x; height: 20px; display: flex;'>" +
+            "<span style='vertical-align: middle; line-height: 20px; 
margin-top: 2px;' class=\"db_image_container\">{0}</span><div 
style='padding-left: 7px;  line-height: 19px;'>{1}</div></div>" +
             "</td>" +
             "<td style='background: url({4});width:2px;'></td>" +
             "</tr></table>")
diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 
b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
index 8f66c9c..38d8104 100644
--- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
+++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
@@ -311,10 +311,6 @@
 .mtev_buttonPanel_pfly_fix label {
     padding-left: 3px !important;
 }
-.db_text {
-    position: relative !important;
-    top: -1px;
-}
 .sdp_helpIconButton_pfly_fix {
     top: -7px !important;
 }
@@ -413,11 +409,6 @@
 }
 .gpv_flowPanel_pfly_fix {
     padding: 4px;
-}
-.gpv_flowPanel_pfly_fix .db_text {
-    position: relative !important;
-    top: -25px !important;
-    left: 20px !important;
 }
 .gpv_flowPanel_pfly_fix .db_image_container img {
     position: relative !important;


-- 
To view, visit http://gerrit.ovirt.org/30821
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icde29a47a3c78f73cca9eaaf0db875c5b82ea0e8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to