Allon Mureinik has posted comments on this change.

Change subject: core: Set images with Storage Pool for images already on target.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/30827/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java:

Line 54:         if (isImagesAlreadyOnTarget()) {
Line 55:             if (!validateUnregisteredEntity(vmFromConfiguration, 
ovfEntityData)) {
Line 56:                 return false;
Line 57:             }
Line 58:             
setImagesWithStoragePoolId(getStorageDomain().getStoragePoolId(), 
getVm().getImages());
argg...
why in the cda and not in the execute?
Line 59:         }
Line 60:         return super.canDoAction();
Line 61:     }
Line 62: 


-- 
To view, visit http://gerrit.ovirt.org/30827
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8546a2ac47dab4208da0df4c2cd7bb92fdde1d40
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to