Martin Peřina has uploaded a new change for review. Change subject: core: Fixes StackOverflowError during fencing ......................................................................
core: Fixes StackOverflowError during fencing Fixes StackOverflowError appeared during execution of fencing operation. This fix removes commandContex instance and overriden getContext() from RestartVdsCommand, because command context in CommandBase should be set always during creation of command and successful locks aquiring is checked prior to executeCommand call in CommandBase. The overriden getContext() has been introduced in Iaf021010188e3c3662fbf8a057da4c58f2600c02. Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c Bug-Url: https://bugzilla.redhat.com/1124141 Signed-off-by: Martin Perina <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/30836/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java index be63dc6..d1dceb29 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java @@ -25,7 +25,6 @@ import org.ovirt.engine.core.common.vdscommands.SetVdsStatusVDSCommandParameters; import org.ovirt.engine.core.common.vdscommands.VDSCommandType; import org.ovirt.engine.core.compat.Guid; -import org.ovirt.engine.core.utils.lock.EngineLock; /** * Send a Stop followed by Start action to a power management device. @@ -44,8 +43,6 @@ */ @NonTransactiveCommandAttribute public class RestartVdsCommand<T extends FenceVdsActionParameters> extends FenceVdsBaseCommand<T> { - - private CommandContext commandContext; protected List<VM> getVmList() { return mVmList; @@ -134,13 +131,6 @@ params.setChangeHostToMaintenanceOnStart(true); } return runInternalAction(action, params, getContext()); - } - - public CommandContext getContext() { - if (commandContext == null) { - commandContext = cloneContext().withLock(new EngineLock(getExclusiveLocks(), null)); - } - return commandContext; } @Override -- To view, visit http://gerrit.ovirt.org/30836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icbe5ad9194b19a390f45c99198087a9e5b68eb9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
