Martin Betak has posted comments on this change. Change subject: frontend: Fix Coverity Scan defect in UiCommon test ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30835/1/frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java File frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseVmModelBehaviorTest.java: Line 110: Line 111: VDSGroup cluster = new VDSGroup(); Line 112: { Line 113: cluster.setcompatibility_version(new Version(3, 5)); Line 114: } > grr, gerrit + formatting = epic fail. Done Line 115: Line 116: @Override Line 117: public VDSGroup getSelectedCluster() { Line 118: return cluster; Line 110: Line 111: VDSGroup cluster = new VDSGroup(); Line 112: { Line 113: cluster.setcompatibility_version(new Version(3, 5)); Line 114: } > This anonymous block is redundant. Also, please use the constants in Versio Well since we are in the body of anonymous class we need to use the initializer block, but we might as well extract it outside of the class into the createModel method body. Line 115: Line 116: @Override Line 117: public VDSGroup getSelectedCluster() { Line 118: return cluster; -- To view, visit http://gerrit.ovirt.org/30835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8bf598c928ed5530a050df45727033c6ff6f464 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
