Alexander Wels has posted comments on this change. Change subject: services: add proxy servlet ......................................................................
Patch Set 6: Looks much better IMO, now I have 2 questions: 1. Maybe we should simply use HttpUrlConnection instead of URLConnection. We can rename createConnection to createHttpConnection and have all the type checking in the createHttpConnection method. That way you don't have to do all the instanceofs and casts in the doGet. 2. Do we want to proxy any other verbs besides GET? -- To view, visit http://gerrit.ovirt.org/30740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia26768ec7a0e06a20f657cae40f6a51303970b44 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
