Liron Aravot has posted comments on this change. Change subject: core: replacing fenceSpmStorage with logic within engine ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30539/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java: Line 168: if (masterDomain != null Line 169: && masterDomain.getStatus() != null Line 170: && (masterDomain.getStatus() == StorageDomainStatus.Active Line 171: || masterDomain.getStatus() == StorageDomainStatus.Unknown || masterDomain.getStatus() == StorageDomainStatus.Inactive)) { Line 172: resetIrs(); > Can you please elaborate why the block of the following "if" statement was I'll return it. Line 173: } Line 174: } Line 175: Line 176: private void resetIrs() { -- To view, visit http://gerrit.ovirt.org/30539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e489cd4ff1f8e8686c89d8ceab72c3af3653a56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
