Alona Kaplan has uploaded a new change for review. Change subject: engine: Adding 'DefaultMtu' to engine-config ......................................................................
engine: Adding 'DefaultMtu' to engine-config Change-Id: Ie45576e4baa5f69ba3fd20ae9a0cad637b7e7b7d Bug-Url: https://bugzilla.redhat.com/1125175 Signed-off-by: Alona Kaplan <[email protected]> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MtuValueHelper.java M packaging/etc/engine-config/engine-config.properties 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/30874/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MtuValueHelper.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MtuValueHelper.java new file mode 100644 index 0000000..536276e --- /dev/null +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MtuValueHelper.java @@ -0,0 +1,22 @@ +package org.ovirt.engine.core.config.entity.helper; + +import org.ovirt.engine.core.common.validation.MTUValidator; +import org.ovirt.engine.core.config.entity.ConfigKey; + +public class MtuValueHelper extends IntegerValueHelper { + + @Override + public ValidationResult validate(ConfigKey key, String value) { + + ValidationResult intValidtionResult = super.validate(key, value); + + if (!intValidtionResult.isOk()) { + return intValidtionResult; + } + + MTUValidator mtuValidator = new MTUValidator(); + return mtuValidator.isValid(Integer.parseInt(value), null) ? new ValidationResult(true) + : new ValidationResult(false, "MTU value is invalid."); + } + +} diff --git a/packaging/etc/engine-config/engine-config.properties b/packaging/etc/engine-config/engine-config.properties index df2e253..fa05330 100644 --- a/packaging/etc/engine-config/engine-config.properties +++ b/packaging/etc/engine-config/engine-config.properties @@ -429,4 +429,5 @@ ClusterRequiredRngSourcesDefault.description="For UI only. Random Number Generator sources that are preselected when creating a new cluster (comma separated string of values 'random' and 'hwrng')" ClusterRequiredRngSourcesDefault.type=StringMultiple ClusterRequiredRngSourcesDefault.validValues=random,hwrng - +DefaultMtu.description="Default MTU value" +DefaultMtu.type=Mtu -- To view, visit http://gerrit.ovirt.org/30874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie45576e4baa5f69ba3fd20ae9a0cad637b7e7b7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
