Allon Mureinik has posted comments on this change. Change subject: core: db sqush 3.2 upgrade scripts ......................................................................
Patch Set 2: (5 comments) I think you're missing some action_version_map inserts - giving -1 to raise visibility. http://gerrit.ovirt.org/#/c/30899/2//COMMIT_MSG Commit Message: Line 19: 6) Creating a database engine_db_squash_3_2 on this patch branch Line 20: 7) Creating a database engine_master on the master branch Line 21: 8) Use pg_dump to export db from step 6) schema & data Line 22: 9) Use pg_dump to export db from step 7) schema & data Line 23: 10)Compare schema & data from steps 8) & 9) Missing space after "10)" Line 24: Line 25: Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8 http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 510: dc_id uuid, Line 511: dc_name character varying, Line 512: spm_host_id uuid, Line 513: spm_host_name character varying, Line 514: task_count integer There doesn't seem to be anything here except for a format change - I would discard it. Line 515: ); Line 516: Line 517: Line 518: create or replace FUNCTION fn_db_get_async_tasks() http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/create_functions.sql File packaging/dbscripts/create_functions.sql: Line 728: storage_id uuid, Line 729: storage_name character varying(250), Line 730: storage_size_gb bigint, Line 731: storage_size_gb_usage double precision Line 732: ); This file too - I'd discard the format changes Line 733: Line 734: CREATE OR REPLACE FUNCTION calculateAllStorageUsage() Line 735: RETURNS SETOF all_storage_usage_rs STABLE Line 736: AS $function$ http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/upgrade/03_02_0240_add_gluster_action_version_map.sql File packaging/dbscripts/upgrade/03_02_0240_add_gluster_action_version_map.sql: Line 47 Line 48 Line 49 Line 50 Line 51 Where are these? I cannot find them in the new scripts. http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/upgrade/03_02_0470_lsm_version_support.sql File packaging/dbscripts/upgrade/03_02_0470_lsm_version_support.sql: Line 1 Line 2 Where are these inserts in the new scripts? -- To view, visit http://gerrit.ovirt.org/30899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
