Kanagaraj M has posted comments on this change. Change subject: engine: Added tables for geo replication entities ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/29947/3/packaging/dbscripts/upgrade/03_06_0070_gluster_georep_tables.sql File packaging/dbscripts/upgrade/03_06_0070_gluster_georep_tables.sql: Line 6: session_key VARCHAR(150) NOT NULL, Line 7: slave_host_name VARCHAR(50), Line 8: slave_host_uuid UUID, Line 9: slave_volume_name VARCHAR(50), Line 10: slave_volume_id UUID, can we change the order? id followed by name Line 11: status VARCHAR, Line 12: _create_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 13: _update_date TIMESTAMP WITH TIME ZONE NOT NULL DEFAULT LOCALTIMESTAMP, Line 14: CONSTRAINT pk_gluster_georep_session PRIMARY KEY(session_id) Line 30: ( Line 31: session_id UUID NOT NULL REFERENCES gluster_georep_session(session_id) ON DELETE CASCADE, Line 32: master_brick_id UUID NOT NULL REFERENCES gluster_volume_bricks(id), Line 33: slave_host_name VARCHAR(50) NOT NULL, Line 34: slave_host_uuid UUID NOT NULL, Will this be different from gluster_georep_session.slave_host_name ? Line 35: status VARCHAR(20), Line 36: checkpoint_status VARCHAR(20), Line 37: crawl_status VARCHAR(20), Line 38: files_synced BIGINT, -- To view, visit http://gerrit.ovirt.org/29947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I231092cfc969030e144a7ddd08187ce1c47a29db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
