Alon Bar-Lev has uploaded a new change for review.

Change subject: aaa: sync: copy isAdmin from existing user
......................................................................

aaa: sync: copy isAdmin from existing user

in role based security there should be no duplication of roles, but in
ovirt-engine schema we have isAdmin marker, although the role can be
queried.

temporary solution is to copy existing user's bit into synced user.

long term solution is to remove this duplication.

Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2
Signed-off-by: Alon Bar-Lev <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/30943/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
index 065b527..3abb306 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java
@@ -64,6 +64,7 @@
                     if (activeUser != null) {
                         if (!activeUser.equals(dbUser)) {
                             activeUser.setId(dbUser.getId());
+                            activeUser.setAdmin(dbUser.isAdmin());
                             log.infoFormat("Principal {0}::{1} synchronized",
                                     activeUser.getLoginName(),
                                     activeUser.getDomain());


-- 
To view, visit http://gerrit.ovirt.org/30943
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id62a2a774c102e3e31c022456809b4b2eb2319b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to