Allon Mureinik has uploaded a new change for review. Change subject: core: AddExistingFileStorageDomain test modifiers ......................................................................
core: AddExistingFileStorageDomain test modifiers Fixed modifiers in AddExistingFileStorageDomainCommandTest to solve compilation warnings. Change-Id: Id4971dc826e36f01a1bac5ac7aba5e39f40cada7 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/30946/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java index b147c8e..7e4957e 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommandTest.java @@ -45,7 +45,7 @@ private AddExistingFileStorageDomainCommand<StorageDomainManagementParameter> command; private StorageDomainManagementParameter parameters; - private static int SD_MAX_NAME_LENGTH = 50; + private static final int SD_MAX_NAME_LENGTH = 50; @ClassRule public static MockConfigRule mcr = new MockConfigRule( @@ -137,7 +137,7 @@ VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_CHANGE_STORAGE_DOMAIN_TYPE); } - private StorageDomainStatic getStorageDomain() { + private static StorageDomainStatic getStorageDomain() { StorageDomainStatic storageDomain = new StorageDomainStatic(); storageDomain.setStorage(Guid.newGuid().toString()); storageDomain.setStorageDomainType(StorageDomainType.Data); @@ -145,14 +145,14 @@ return storageDomain; } - private StoragePool getStoragePool() { + private static StoragePool getStoragePool() { StoragePool storagePool = new StoragePool(); storagePool.setId(Guid.newGuid()); storagePool.setcompatibility_version(Version.v3_5); return storagePool; } - private List<VDS> getHosts() { + private static List<VDS> getHosts() { List<VDS> hosts = new ArrayList<>(); VDS host = new VDS(); host.setId(Guid.newGuid()); -- To view, visit http://gerrit.ovirt.org/30946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id4971dc826e36f01a1bac5ac7aba5e39f40cada7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
