Roy Golan has posted comments on this change. Change subject: core: pass MaxNumberOfSockets to create verb ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30877/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 78: createInfo.put(VdsProperties.smartcardEnabled, Boolean.toString(vm.isSmartcardEnabled())); Line 79: createInfo.put(VdsProperties.num_of_cpus, String.valueOf(vm.getNumOfCpus())); Line 80: if (Config.<Boolean> getValue(ConfigValues.SendSMPOnRunVm)) { Line 81: createInfo.put(VdsProperties.cores_per_socket, (Integer.toString(vm.getCpuPerSocket()))); Line 82: createInfo.put(VdsProperties.max_number_of_sockets, Config.<Integer> getValue(ConfigValues.MaxNumOfVmSockets).toString()); > so is this per cluster level? it should be indeed. fixed Line 83: if (FeatureSupported.supportedInConfig(ConfigValues.HotPlugCpuSupported, Line 84: vm.getVdsGroupCompatibilityVersion(), Line 85: vm.getClusterArch())) { Line 86: createInfo.put( -- To view, visit http://gerrit.ovirt.org/30877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68368fdd40f0e43df18465c15faf2626789ee1c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
