Juan Hernandez has posted comments on this change. Change subject: engine: fix setup that will work with the new engine-config password policy ......................................................................
Patch Set 4: (2 inline comments) See the reasons for the failure in the inline comments. I will submit a new patch set in a few minutes. .................................................... File packaging/fedora/setup/common_utils.py Line 708: option = key + ' --admin-pass-file=' + filePath This value of "option" will be passed as one of the arguments of the "exec" system call, including the space, so engine-config will receive the list of argumetnts [..., "-s", "CertificatePassword --amdin-pass-file=/tmp/whatever", ...]. So engine-config will fail with a really obscure and unrelated class cast exception. .................................................... File packaging/fedora/setup/engine-setup.py Line 1047: "keystorePass":[basedefs.CONST_CA_PASS, 'pass'], These two options shouldn't be handled as passwords, as that implies encrypting them in the database, which makes no sense. -- To view, visit http://gerrit.ovirt.org/6074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b18c6911f87b369561a7edbde2002bc1d7ce9df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
