Ayal Baron has posted comments on this change. Change subject: core: support adding disk while VM is UP ......................................................................
Patch Set 3: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java Line 323: getVm().getstatus() == VMStatus.Down, code would be much clearer if this is first assigned to a temp variable with a meaningful name. e.g. Boolean diskActive = getVm().getstatus() == VMStatus.Down Line 353: getVm().getstatus() == VMStatus.Down, same as above -- To view, visit http://gerrit.ovirt.org/6106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475ab7ccc2e1a016aa1909f9b60bf2c4c9f3b11a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
