Gilad Chaplik has posted comments on this change. Change subject: webadmin: add permission splitter to disk profiles ......................................................................
Patch Set 2: (3 comments) new patch to follow http://gerrit.ovirt.org/#/c/30647/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/DiskProfilesListModelTable.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/DiskProfilesListModelTable.java: Line 78: @Override Line 79: public String getValue(DiskProfile object) { Line 80: return object.getName(); Line 81: } Line 82: }; > We probably want to make this column sortable. This should do it: Done Line 83: getTable().addColumn(nameColumn, constants.diskProfileNameLabel(), "200px"); //$NON-NLS-1$ Line 84: Line 85: TextColumnWithTooltip<DiskProfile> descriptionColumn = Line 86: new TextColumnWithTooltip<DiskProfile>() { Line 87: @Override Line 88: public String getValue(DiskProfile object) { Line 89: return object.getDescription(); Line 90: } Line 91: }; > We probably want to make this column sortable. Done Line 92: getTable().addColumn(descriptionColumn, constants.diskProfileDescriptionLabel(), "200px"); //$NON-NLS-1$ Line 93: Line 94: TextColumnWithTooltip<DiskProfile> qosColumn = new TextColumnWithTooltip<DiskProfile>() { Line 95: @Override Line 102: } Line 103: } Line 104: return name; Line 105: } Line 106: }; > We probably want to make this column sortable. might have to look at other currently there's not backend support for this field, so.. Done. Line 107: getTable().addColumn(qosColumn, constants.storageQosName(), "200px"); //$NON-NLS-1$ Line 108: Line 109: getTable().addActionButton(new WebAdminButtonDefinition<DiskProfile>(constants.newDiskProfile()) { Line 110: @Override -- To view, visit http://gerrit.ovirt.org/30647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcc953a2685406ae4883602e00beff0440f1be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
