Adam Litke has posted comments on this change. Change subject: Provide configuration options for socket name and socket extension ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28608/2/doc/mom-balloon%2Bksm.conf File doc/mom-balloon+ksm.conf: Line 98: # Set the socket extension Line 99: # Default is sock Line 100: # The GuestQemuAgent Collector will try to open the socket: Line 101: # <socket_path>/<socket_name>.<guest-name>.<socket_extension> Line 102: socket_extension: sock > I was following the example over here - http://aglitke.wordpress.com/2011/0 In an ideal world, we'd combine all three settings into a single setting 'socket_pattern' that would use a replacement string for guest name substitution such as: socket_name: /var/lib/libvirt/qemu/org.qemu.guest_agent.0.%(name).sock mom would substitute the guest name in using the % operator. To maintain backwards compatibility with old config files, we need to preserve the current behavior of the socket_path var but if socket_name is specified then we can adopt the new behavior above. What do you think? Line 103: Line 104: [Collector: GuestNetworkDaemon] Line 105: # Helper program to convert guest names to IP addresses. This is only used by Line 106: # the GuestNetworkDaemon Collector. See doc/name-to-ip for an example. -- To view, visit http://gerrit.ovirt.org/28608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf7d915f7bb3e5544625aa16205765e4099c6f57 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Meghal .B. Gosalia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
