Alon Bar-Lev has uploaded a new change for review. Change subject: core: Adding context ctor to UpgradeOvirtNodeInternalCommand ......................................................................
core: Adding context ctor to UpgradeOvirtNodeInternalCommand I still fail to understand why not add to all commands. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720 Change-Id: I0555fd221f1fd3dfd8c4dbd35e5cc0fc919b3906 Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/31053/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java index 07174a6..af2797a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommand.java @@ -1,11 +1,12 @@ package org.ovirt.engine.core.bll; -import org.apache.commons.lang.exception.ExceptionUtils; import org.apache.commons.lang.StringUtils; +import org.apache.commons.lang.exception.ExceptionUtils; +import org.ovirt.engine.core.bll.context.CommandContext; import org.ovirt.engine.core.common.AuditLogType; import org.ovirt.engine.core.common.action.InstallVdsParameters; -import org.ovirt.engine.core.common.action.LockProperties; import org.ovirt.engine.core.common.action.LockProperties.Scope; +import org.ovirt.engine.core.common.action.LockProperties; import org.ovirt.engine.core.common.businessentities.VDSStatus; import org.ovirt.engine.core.common.businessentities.VDSType; import org.ovirt.engine.core.common.errors.VdcBllMessages; @@ -89,8 +90,8 @@ return ret; } - public UpgradeOvirtNodeInternalCommand(T parameters) { - super(parameters); + public UpgradeOvirtNodeInternalCommand(T parameters, CommandContext cmdContext) { + super(parameters, cmdContext); } @Override diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java index fa4a87c..a02524d 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpgradeOvirtNodeInternalCommandTest.java @@ -47,7 +47,7 @@ private VdsDAO vdsDAO; private UpgradeOvirtNodeInternalCommand<InstallVdsParameters> createCommand(InstallVdsParameters params) { - UpgradeOvirtNodeInternalCommand<InstallVdsParameters> command = spy(new UpgradeOvirtNodeInternalCommand<InstallVdsParameters>(params)); + UpgradeOvirtNodeInternalCommand<InstallVdsParameters> command = spy(new UpgradeOvirtNodeInternalCommand<InstallVdsParameters>(params, null)); doReturn(vdsDAO).when(command).getVdsDAO(); return command; } -- To view, visit http://gerrit.ovirt.org/31053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0555fd221f1fd3dfd8c4dbd35e5cc0fc919b3906 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
