Shahar Havivi has posted comments on this change. Change subject: webadmin: Allow selection of None for Cloud-Init network boot protocol ......................................................................
Patch Set 1: (2 comments) Greg, Did you test this via REST API as well? Did you check that VMs that we created with the UseDHCP checkbox having the right value in the new selectbox? Thanks. http://gerrit.ovirt.org/#/c/31051/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java: Line 514: sysprepDomainEditor.addStyleName(customizableStyle.primaryOption()); Line 515: networkBootProtocolEditor.addStyleName(customizableStyle.primaryOption()); Line 516: networkIpAddressEditor.addStyleName(customizableStyle.primaryOption()); Line 517: networkNetmaskEditor.addStyleName(customizableStyle.primaryOption()); Line 518: networkGatewayEditor.addStyleName(customizableStyle.primaryOption()); Why did you needed to add the style here? Line 519: networkStartOnBootEditor.addStyleName(customizableStyle.primaryOption()); Line 520: Line 521: windowsSysprepTimeZoneEditor.addStyleName(customizableStyle.primaryOption()); Line 522: inputLocaleEditor.addStyleName(customizableStyle.primaryOption()); http://gerrit.ovirt.org/#/c/31051/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java: Line 569: Line 570: Map<String, NetworkBootProtocol> networkBootProtocols = new HashMap<String, NetworkBootProtocol>(); Line 571: networkBootProtocols.put("None", NetworkBootProtocol.NONE); //$NON-NLS-1$ Line 572: networkBootProtocols.put("DHCP", NetworkBootProtocol.DHCP); //$NON-NLS-1$ Line 573: networkBootProtocols.put("Static IP", NetworkBootProtocol.STATIC_IP); //$NON-NLS-1$ Please add this strings to UIConstants.java (If we get a request for localizing this strings) Line 574: getNetworkBootProtocolList().setItems(networkBootProtocols.entrySet()); Line 575: getNetworkBootProtocolList().setSelectedItem(Linq.firstOrDefault(networkBootProtocols.entrySet(), Line 576: new IPredicate<Map.Entry<String, NetworkBootProtocol>>() { Line 577: @Override -- To view, visit http://gerrit.ovirt.org/31051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51a76e968922fb62a07ccaced969c8b580de083 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
