Martin Peřina has posted comments on this change. Change subject: core: Add VdsSpmIdMapDAO.get(storagePoolId, vdsId) ......................................................................
Patch Set 1: Well, I didn't noticed this method, because you have VdsSpmIdMapDAODbFacadeImpl.get(Guid vdsId) but no VdsSpmIdMapDAO.get(Guid vdsId). So if agreed I will change this patch to make this method public, use it in my code and drop get(Guid storagePoolId, Guid vdsId) method introduced in this patch. -- To view, visit http://gerrit.ovirt.org/30937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic590281545123788ce62c740901c69de0ed00c33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
