Shahar Havivi has uploaded a new change for review. Change subject: engine: search: vms.uptime is not working ......................................................................
engine: search: vms.uptime is not working when searching for vms: vms.uptime > 01:00 we use the TimeSpan.TotalSeconds which is always zero (we never pass the seconds only days, hours and minutes) instead of using the TimeSpan.TotalMilliseconds which hold the true total time. Bug-Url: https://bugzilla.redhat.com/1005805 Change-Id: I322a253557c71888307a60e7ae685dd38d637543 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/66/31066/1 diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java index 3493a07..fd81498 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java @@ -2,7 +2,6 @@ import java.util.Date; import java.util.UUID; - import org.ovirt.engine.core.common.businessentities.ArchitectureType; import org.ovirt.engine.core.common.businessentities.VMStatus; import org.ovirt.engine.core.common.businessentities.VmType; @@ -40,6 +39,8 @@ public static final String ID = "ID"; public static final String DESCRIPTION = "DESCRIPTION"; public static final String ARCHITECTURE = "ARCHITECTURE"; + + private static final int MILISECOND = 1000; public VmConditionFieldAutoCompleter() { // Building the basic verbs Dict @@ -187,7 +188,7 @@ else if (UPTIME.equals(fieldName)) { pair.setSecond(StringHelper.trim(pair.getSecond(), '\'')); TimeSpan ts = TimeSpan.parse(pair.getSecond()); - pair.setSecond(StringFormat.format("'%1$s'", ts.TotalSeconds)); + pair.setSecond(StringFormat.format("'%1$s'", ts.TotalMilliseconds < MILISECOND ? 0 : ts.TotalMilliseconds / MILISECOND)); } else if (CREATIONDATE.equals(fieldName)) { Date tmp = new Date(Date.parse(StringHelper.trim(pair.getSecond(), '\''))); -- To view, visit http://gerrit.ovirt.org/31066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I322a253557c71888307a60e7ae685dd38d637543 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
