Sandro Bonazzola has posted comments on this change. Change subject: ovirt-iso-uploader: Add creation of VDSM user ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31064/2/ovirt-iso-uploader.spec.in File ovirt-iso-uploader.spec.in: Line 31: Line 32: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release} Line 33: BuildArch: noarch Line 34: Requires: python Line 35: Requires: ovirt-engine-sdk-python >= 3.6.0.0 You'll need: Requires(pre): shadow-utils in order to have getent. See http://fedoraproject.org/wiki/Packaging:UsersAndGroups Line 36: Requires: logrotate Line 37: BuildRequires: gettext Line 38: BuildRequires: python2-devel Line 39: Line 56: Line 57: /usr/bin/getent passwd %{vdsm_user} >/dev/null || \ Line 58: /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \ Line 59: -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user} Line 60: No need to use full path of the commands here. Also missing: exit 0 http://fedoraproject.org/wiki/Packaging:UsersAndGroups#Rationale_for_some_of_the_implementation_choices Line 61: %install Line 62: rm -rf "%{buildroot}" Line 63: make %{?_smp_mflags} install DESTDIR="%{buildroot}" Line 64: -- To view, visit http://gerrit.ovirt.org/31064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd024327e9263f3523fd39f632d694d55fc78161 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
