Sandro Bonazzola has posted comments on this change. Change subject: net_config: use vdscli and setupNetworks ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28595/4/src/plugins/ovirt-hosted-engine-setup/network/bridge.py File src/plugins/ovirt-hosted-engine-setup/network/bridge.py: Line 265: if code != 0: Line 266: raise RuntimeError('Failed to persist network configuration. ' Line 267: 'Error code: "%s" message: "%s"' % Line 268: (code, message)) Line 269: please use 2 empty lines here -- To view, visit http://gerrit.ovirt.org/28595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1923870adcb81f4e6bb5c6c1cc819d2e6e49aa2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
