Liron Aravot has posted comments on this change. Change subject: core: Calculate storage format when adding an SD ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30960/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 168: sd.setStorageFormat(VersionStorageFormatUtil.getPreferredForVersion( Line 169: sp.getcompatibility_version(), sd.getStorageType()) Line 170: ); Line 171: } else { Line 172: sd.setStorageFormat(StorageFormatType.V3); if the host doesn't support the v3 format (old vdsm version), we'll fail when trying to add the domain. i think that if there's no pool, we can add the domain as v1 (it's rare enough anyway)..in the worst case, it'll be upgraded. Line 173: } Line 174: } else { Line 175: sd.setStorageFormat(StorageFormatType.V1); Line 176: } -- To view, visit http://gerrit.ovirt.org/30960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If469bb655e9a65e2d0afcee164655fa0bdfa5d99 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
