Meghal .B. Gosalia has posted comments on this change. Change subject: Support socket name configuration in template form ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28608/5/doc/mom-balloon%2Bksm.conf File doc/mom-balloon+ksm.conf: Line 97: # socketname will be instance-00000001.agent. Line 98: # The GuestQemuAgent Collector will try to open the socket: Line 99: # <socket_path>/<socket_name_template> Line 100: # after guest name substitution in the template. Line 101: socket_name_template: %(name)s.agent > Please make the default compatible with the libvirt naming convention since Sure. I can change it to org.qemu.guest_agent.0.%(name)s.sock. But was wondering that in order to maintain backwards compatibility with previous versions of mom, we agreed to use %(name)s.agent. Line 102: Line 103: [Collector: GuestNetworkDaemon] Line 104: # Helper program to convert guest names to IP addresses. This is only used by Line 105: # the GuestNetworkDaemon Collector. See doc/name-to-ip for an example. http://gerrit.ovirt.org/#/c/28608/5/mom/Collectors/Collector.py File mom/Collectors/Collector.py: Line 80 Line 81 Line 82 Line 83 Line 84 > Hmm, I am concerned about this change since it affects all Collector config Without this %(name)s configuration parameter throws this error: File "/usr/lib/python2.6/site-packages/mom/GuestManager.py", line 116, in run self.spawn_guest_monitors(domain_list) File "/usr/lib/python2.6/site-packages/mom/GuestManager.py", line 55, in spawn_guest_monitors guest = GuestMonitor(self.config, info, self.hypervisor_iface) File "/usr/lib/python2.6/site-packages/mom/GuestMonitor.py", line 45, in __init__ self.properties, self.config) File "/usr/lib/python2.6/site-packages/mom/Collectors/Collector.py", line 83, in get_collectors properties['config'] = dict(global_config.items(section)) File "/usr/lib64/python2.6/ConfigParser.py", line 578, in items for option in options] File "/usr/lib64/python2.6/ConfigParser.py", line 614, in _interpolate self._interpolate_some(option, L, rawval, section, vars, 1) File "/usr/lib64/python2.6/ConfigParser.py", line 646, in _interpolate_some option, section, rest, var) InterpolationMissingOptionError: Bad value substitution: section: [Collector: GuestQemuAgent] option : socket_name_template key : name rawval : .agent -- To view, visit http://gerrit.ovirt.org/28608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf7d915f7bb3e5544625aa16205765e4099c6f57 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Meghal .B. Gosalia <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Meghal .B. Gosalia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
