Hello Tomas Jelinek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/31132
to review the following change.
Change subject: userportal,webadmin: webadmin fixes for VM dialog
......................................................................
userportal,webadmin: webadmin fixes for VM dialog
In FR locale new VM/pool dialog had some issues. Fixed by making the dialog
bigger and setting the proper style to SerialNumberPolicyWidget's checkbox.
Change-Id: I7e8659f3aee8d8ce3a67c97c9fda2d2546175f0c
Bug-Url: https://bugzilla.redhat.com/1123735
Signed-off-by: Tomas Jelinek <[email protected]>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java
5 files changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/31132/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
index d124362..4444819 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
@@ -20,7 +20,7 @@
@Inject
public AbstractVmPopupView(EventBus eventBus, CommonApplicationResources
resources,
AbstractVmPopupWidget popupWidget) {
- this(eventBus, resources, popupWidget, "690px", "580px");
//$NON-NLS-1$ //$NON-NLS-2$
+ this(eventBus, resources, popupWidget, "760px", "580px");
//$NON-NLS-1$ //$NON-NLS-2$
}
public AbstractVmPopupView(EventBus eventBus, CommonApplicationResources
resources,
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
index e4785df..16a6c79 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
@@ -492,7 +492,7 @@
</g:FlowPanel>
<g:Label ui:field="generalLabel"
addStyleNames="{style.sectionLabel}" text="{constants.initialRunGeneral}" />
<w:EntityModelWidgetWithInfo
ui:field="timeZoneEditorWithInfo" />
- <vm:SerialNumberPolicyWidget
ui:field="serialNumberPolicyEditor" />
+ <vm:SerialNumberPolicyWidget
ui:field="serialNumberPolicyEditor"
checkboxStyle="{style.checkboxWithLongLabel}" />
</g:FlowPanel>
</t:content>
</t:DialogTab>
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
index fcc5be4..6087dd9 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/SerialNumberPolicyWidget.java
@@ -83,4 +83,8 @@
public SerialNumberPolicyModel flush() {
return driver.flush();
}
+
+ public void setCheckboxStyle(String checkboxStyle) {
+ overrideSerialNumberPolicy.addStyleName(checkboxStyle);
+ }
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java
index 6a57c50..46a6e9b 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java
@@ -21,7 +21,7 @@
@Inject
public PoolEditPopupView(EventBus eventBus, ApplicationResources
resources, ApplicationConstants constants, CommonApplicationMessages messages,
CommonApplicationTemplates templates) {
- super(eventBus, resources, new PoolEditPopupWidget(constants,
resources, messages, templates, eventBus), "710px", "570px"); //$NON-NLS-1$
//$NON-NLS-2$
+ super(eventBus, resources, new PoolEditPopupWidget(constants,
resources, messages, templates, eventBus), "760px", "570px"); //$NON-NLS-1$
//$NON-NLS-2$
ViewIdHandler.idHandler.generateAndSetIds(this);
}
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java
index dd69539..2077d6e 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolNewPopupView.java
@@ -21,7 +21,7 @@
@Inject
public PoolNewPopupView(EventBus eventBus, ApplicationResources resources,
ApplicationConstants constants, CommonApplicationMessages messages,
CommonApplicationTemplates templates) {
- super(eventBus, resources, new PoolNewPopupWidget(constants,
resources, messages, templates, eventBus), "690px", "580px"); //$NON-NLS-1$
//$NON-NLS-2$
+ super(eventBus, resources, new PoolNewPopupWidget(constants,
resources, messages, templates, eventBus), "760px", "580px"); //$NON-NLS-1$
//$NON-NLS-2$
ViewIdHandler.idHandler.generateAndSetIds(this);
}
--
To view, visit http://gerrit.ovirt.org/31132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e8659f3aee8d8ce3a67c97c9fda2d2546175f0c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
