Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: layout: hide overflow of forms. ......................................................................
Patch Set 6: Okay, I see where you are hiding the overflow, its the bottom panel that contains the buttons, but that leaves one problem, if you look at the bottom right of your screenshot, the down arrow of the scrollbar is gone. I am also willing to bet, that if you scroll all the way to the bottom you are missing the bottom line. IMO the real problem is that the margin of the hr between 'Account type' and 'Check boxes to Allow Action' is 20 pixels on the top and bottom. Looking at the style sheets this margin comes from styles-min.css and thus I think that is caused by patternfly? Might need to add a new style to the hr in RolePopupView.ui.xml. So instead of: <g:HTML><hr style="width:100%;" /></g:HTML> do <g:HTML><hr style="width:100%;padding: 5px 0px" /></g:HTML> -- To view, visit http://gerrit.ovirt.org/30999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a70fddc20f9179b55cd6d80b877ed6ec30de074 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
