Michael Kublin has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 124: if (disk.getDiskStorageType() == DiskStorageType.IMAGE) {
Agreed with Ayal , it's basically there to provide safety in case that another
future disk type would support snapshots - or we are scared of our shadow or we
are trying to predict a future.
Line 129: diskImage.setvm_snapshot_id(snapshotId);
You understand that there are no any sense to write that line:
diskImage.setvm_snapshot_id(snapshotId); ? It is means that u wrote a test
based on unnecessary and unneeded code
--
To view, visit http://gerrit.ovirt.org/5718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0945cecc63dc041fdb56e2fd7b733b287a9904c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
