Tomas Jelinek has uploaded a new change for review. Change subject: userportal,webadmin: redesign vCPU editing (#809800) ......................................................................
userportal,webadmin: redesign vCPU editing (#809800) https://bugzilla.redhat.com/809800 The new design is now the following: - There is one slider with label "Num of vCPUs" - This slider has an editable text box next to it - There is an "Advanced Parameters" section, which contains two combo boxes: - "Cores per Socket" - "Num of Sockets" The behaviour is as follows: - When the "Num of vCPUs" changes to new correct value, than: 1 when some value is already selekted in the "Cores per Socket", it tries to set the value of the "Num of Sockets" to compose the new "Num of CPUs" but preserving the "Cores per Socket" (e.g. "Cores per Socket" is 2 and "Num of vCPUs" changed to 12, the "Num of Sockets" will be changed to 6). 2 If the "Cores per Socket" is not set or can not be used to compose the new "Num of vCPUs", than the "Cores per Socket" and "Num of Sockets" are automatically adjusted to the new values, while the "Num of Sockets" tries to be the biggest possible (but not bigger, than the predefined value from vdc_options). For example, bothe the max enabled "Num of Scokets" and "Cores per Socket" is 16 and the "Num of vCPU" moves to 18, than the "Num of Sockets" will be 9 and the "Cores per socket" 2. 3 The combo boxes will be filled by values, which can be used to compose the selected num of vCPUs. - When the "Num of vCPUs" changes to new incorrect value, than: - the "Cores per Socket" and "Num of Sockets" gets disabled and the warning message: "Incorrect number of vCPUs because it can not be composed from the available sockets and cores per sockets" is shown under the slider - When the dialog gets submitted with the incorrect num of vCPUs set, there is a validation with message: "Incorrect number of vCPUs. It is not possible to compose this number from the available Sockets and Cores per Sockets" - When one of the combo boxes changes, the second one is automatically adjusted to the value to compose the selected vCPUs amount. - The combo boxes never contains values, which can not compose the defined vCPUs amount. Change-Id: I75cc943dfa986546878b3ae5faae3cfb637fb188 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelSliderWithTextBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 19 files changed, 500 insertions(+), 155 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/6184/1 -- To view, visit http://gerrit.ovirt.org/6184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75cc943dfa986546878b3ae5faae3cfb637fb188 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
