Ravi Nori has posted comments on this change. Change subject: engine: Add AddVmTemplateCommand to command executer framework ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31180/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 305: pendingAsyncTasks = !getReturnValue().getVdsmTaskIdList().isEmpty(); Line 306: if (!pendingAsyncTasks) { Line 307: endSuccessfullySynchronous(); Line 308: } Line 309: persistCommand(getParameters().getParentCommand(), false); > ravi, is persistCommand required here? In the current master we need to call persist explicitly. We need to simplify this, so the commands need not invoke the second persist. Line 310: setCommandStatus(CommandStatus.SUCCEEDED); Line 311: } Line 312: Line 313: private boolean doClusterRelatedChecks() { -- To view, visit http://gerrit.ovirt.org/31180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
